Fixing risky tests

Makring tests that have no assertions with the annotation to suppress phpunits warning around risky tests closes 1370
php-enqueue · Jan 11, 2025 · a2177a5 · a2177a5
1 parent 48d3303
commit a2177a5
Show file tree

Hide file tree

Showing 120 changed files with 421 additions and 0 deletions.
diff --git a/pkg/amqp-bunny/Tests/AmqpConsumerTest.php b/pkg/amqp-bunny/Tests/AmqpConsumerTest.php
@@ -27,6 +27,9 @@ public function testShouldImplementConsumerInterface()
         $this->assertClassImplements(Consumer::class, AmqpConsumer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithContextAndQueueAsArguments()
     {
         new AmqpConsumer($this->createContextMock(), new AmqpQueue('aName'));

diff --git a/pkg/amqp-bunny/Tests/AmqpProducerTest.php b/pkg/amqp-bunny/Tests/AmqpProducerTest.php
@@ -24,6 +24,10 @@ class AmqpProducerTest extends TestCase
 {
     use ClassExtensionTrait;
 
+    /**
+     * @doesNotPerformAssertions
+     */
+
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new AmqpProducer($this->createBunnyChannelMock(), $this->createContextMock());

diff --git a/pkg/amqp-bunny/Tests/AmqpSubscriptionConsumerTest.php b/pkg/amqp-bunny/Tests/AmqpSubscriptionConsumerTest.php
@@ -17,6 +17,9 @@ public function testShouldImplementQueueInteropSubscriptionConsumerInterface()
         $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithAmqpContextAsFirstArgument()
     {
         new AmqpSubscriptionConsumer($this->createAmqpContextMock());

diff --git a/pkg/amqp-ext/Tests/AmqpConsumerTest.php b/pkg/amqp-ext/Tests/AmqpConsumerTest.php
@@ -19,6 +19,9 @@ public function testShouldImplementConsumerInterface()
         $this->assertClassImplements(Consumer::class, AmqpConsumer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithContextAndQueueAsArguments()
     {
         new AmqpConsumer($this->createContext(), new AmqpQueue('aName'));

diff --git a/pkg/amqp-ext/Tests/AmqpContextTest.php b/pkg/amqp-ext/Tests/AmqpContextTest.php
@@ -28,11 +28,17 @@ public function testShouldImplementQueueInteropContextInterface()
         $this->assertClassImplements(Context::class, AmqpContext::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExtChannelAsFirstArgument()
     {
         new AmqpContext($this->createExtChannelMock());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExtChannelCallbackFactoryAsFirstArgument()
     {
         new AmqpContext(function () {

diff --git a/pkg/amqp-ext/Tests/AmqpSubscriptionConsumerTest.php b/pkg/amqp-ext/Tests/AmqpSubscriptionConsumerTest.php
@@ -17,6 +17,9 @@ public function testShouldImplementQueueInteropSubscriptionConsumerInterface()
         $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithAmqpContextAsFirstArgument()
     {
         new AmqpSubscriptionConsumer($this->createAmqpContextMock());

diff --git a/pkg/async-event-dispatcher/Tests/AsyncProcessorTest.php b/pkg/async-event-dispatcher/Tests/AsyncProcessorTest.php
@@ -24,6 +24,9 @@ public function testShouldImplementProcessorInterface()
         $this->assertClassImplements(Processor::class, AsyncProcessor::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRegistryAndProxyEventDispatcher()
     {
         new AsyncProcessor($this->createRegistryMock(), $this->createProxyEventDispatcherMock());

diff --git a/pkg/async-event-dispatcher/Tests/PhpSerializerEventTransformerTest.php b/pkg/async-event-dispatcher/Tests/PhpSerializerEventTransformerTest.php
@@ -21,6 +21,9 @@ public function testShouldImplementEventTransformerInterface()
         $this->assertClassImplements(EventTransformer::class, PhpSerializerEventTransformer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new PhpSerializerEventTransformer($this->createContextStub());

diff --git a/pkg/async-event-dispatcher/Tests/SimpleRegistryTest.php b/pkg/async-event-dispatcher/Tests/SimpleRegistryTest.php
@@ -18,6 +18,9 @@ public function testShouldImplementRegistryInterface()
         $this->assertClassImplements(Registry::class, SimpleRegistry::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithEventsMapAndTransformersMapAsArguments()
     {
         new SimpleRegistry([], []);

diff --git a/pkg/dbal/Tests/DbalConsumerTest.php b/pkg/dbal/Tests/DbalConsumerTest.php
@@ -28,6 +28,9 @@ public function testShouldImplementConsumerInterface()
         $this->assertClassImplements(Consumer::class, DbalConsumer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new DbalConsumer($this->createContextMock(), new DbalDestination('queue'));

diff --git a/pkg/dbal/Tests/DbalContextTest.php b/pkg/dbal/Tests/DbalContextTest.php
@@ -27,6 +27,9 @@ public function testShouldImplementContextInterface()
         $this->assertClassImplements(Context::class, DbalContext::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new DbalContext($this->createConnectionMock());

diff --git a/pkg/dbal/Tests/DbalProducerTest.php b/pkg/dbal/Tests/DbalProducerTest.php
@@ -21,6 +21,9 @@ public function testShouldImplementProducerInterface()
         $this->assertClassImplements(Producer::class, DbalProducer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new DbalProducer($this->createContextMock());

diff --git a/pkg/dbal/Tests/DbalSubscriptionConsumerTest.php b/pkg/dbal/Tests/DbalSubscriptionConsumerTest.php
@@ -25,6 +25,9 @@ public function testShouldImplementSubscriptionConsumerInterface()
         $this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithDbalContextAsFirstArgument()
     {
         new DbalSubscriptionConsumer($this->createDbalContextMock());
@@ -66,6 +69,9 @@ public function testThrowsIfTrySubscribeAnotherConsumerToAlreadySubscribedQueue(
         $subscriptionConsumer->subscribe($barConsumer, $barCallback);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testShouldAllowSubscribeSameConsumerAndCallbackSecondTime()
     {
         $subscriptionConsumer = new DbalSubscriptionConsumer($this->createDbalContextMock());

diff --git a/pkg/dsn/Tests/DsnTest.php b/pkg/dsn/Tests/DsnTest.php
@@ -8,6 +8,9 @@
 
 class DsnTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithDsnAsFirstArgument()
     {
         Dsn::parseFirst('foo://localhost:1234');

diff --git a/...enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrineClearIdentityMapExtensionTest.php b/...enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrineClearIdentityMapExtensionTest.php
@@ -16,6 +16,9 @@
 
 class DoctrineClearIdentityMapExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new DoctrineClearIdentityMapExtension($this->createRegistryMock());

diff --git a/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrinePingConnectionExtensionTest.php b/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/DoctrinePingConnectionExtensionTest.php
@@ -17,6 +17,9 @@
 
 class DoctrinePingConnectionExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredAttributes()
     {
         new DoctrinePingConnectionExtension($this->createRegistryMock());

diff --git a/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/ResetServicesExtensionTest.php b/pkg/enqueue-bundle/Tests/Unit/Consumption/Extension/ResetServicesExtensionTest.php
@@ -16,6 +16,9 @@
 
 class ResetServicesExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new ResetServicesExtension($this->createResetterMock());

diff --git a/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/ConfigurationTest.php b/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/ConfigurationTest.php
@@ -25,6 +25,9 @@ public function testShouldBeFinal()
         $this->assertClassFinal(Configuration::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithDebugAsArgument()
     {
         new Configuration(true);

diff --git a/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/EnqueueExtensionTest.php b/pkg/enqueue-bundle/Tests/Unit/DependencyInjection/EnqueueExtensionTest.php
@@ -30,6 +30,9 @@ public function testShouldBeFinal()
         $this->assertClassFinal(EnqueueExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new EnqueueExtension();

diff --git a/pkg/enqueue-bundle/Tests/Unit/EnqueueBundleTest.php b/pkg/enqueue-bundle/Tests/Unit/EnqueueBundleTest.php
@@ -16,6 +16,9 @@ public function testShouldExtendBundleClass()
         $this->assertClassExtends(Bundle::class, EnqueueBundle::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new EnqueueBundle();

diff --git a/pkg/enqueue-bundle/Tests/Unit/Profiler/MessageQueueCollectorTest.php b/pkg/enqueue-bundle/Tests/Unit/Profiler/MessageQueueCollectorTest.php
@@ -23,6 +23,9 @@ public function testShouldExtendDataCollectorClass()
         $this->assertClassExtends(DataCollector::class, MessageQueueCollector::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithEmptyConstructor()
     {
         new MessageQueueCollector();

diff --git a/pkg/enqueue/Tests/ArrayProcessorRegistryTest.php b/pkg/enqueue/Tests/ArrayProcessorRegistryTest.php
@@ -18,6 +18,9 @@ public function testShouldImplementProcessorRegistryInterface()
         $this->assertClassImplements(ProcessorRegistryInterface::class, ArrayProcessorRegistry::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArgument()
     {
         new ArrayProcessorRegistry();

diff --git a/pkg/enqueue/Tests/Client/ChainExtensionTest.php b/pkg/enqueue/Tests/Client/ChainExtensionTest.php
@@ -29,6 +29,9 @@ public function testShouldBeFinal()
         $this->assertClassFinal(ChainExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExtensionsArray()
     {
         new ChainExtension([$this->createExtension(), $this->createExtension()]);

diff --git a/pkg/enqueue/Tests/Client/ConsumptionExtension/DelayRedeliveredMessageExtensionTest.php b/pkg/enqueue/Tests/Client/ConsumptionExtension/DelayRedeliveredMessageExtensionTest.php
@@ -23,6 +23,9 @@
 
 class DelayRedeliveredMessageExtensionTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new DelayRedeliveredMessageExtension($this->createDriverMock(), 12345);

diff --git a/pkg/enqueue/Tests/Client/ConsumptionExtension/ExclusiveCommandExtensionTest.php b/pkg/enqueue/Tests/Client/ConsumptionExtension/ExclusiveCommandExtensionTest.php
@@ -34,6 +34,9 @@ public function testShouldBeFinal()
         $this->assertClassFinal(ExclusiveCommandExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithDriverAsFirstArgument()
     {
         new ExclusiveCommandExtension($this->createDriverStub());

diff --git a/pkg/enqueue/Tests/Client/ConsumptionExtension/FlushSpoolProducerExtensionTest.php b/pkg/enqueue/Tests/Client/ConsumptionExtension/FlushSpoolProducerExtensionTest.php
@@ -30,6 +30,9 @@ public function testShouldImplementEndExtensionInterface()
         $this->assertClassImplements(EndExtensionInterface::class, FlushSpoolProducerExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithSpoolProducerAsFirstArgument()
     {
         new FlushSpoolProducerExtension($this->createSpoolProducerMock());

diff --git a/pkg/enqueue/Tests/Client/ConsumptionExtension/LogExtensionTest.php b/pkg/enqueue/Tests/Client/ConsumptionExtension/LogExtensionTest.php
@@ -55,6 +55,9 @@ public function testShouldSubClassOfLogExtension()
         $this->assertClassExtends(\Enqueue\Consumption\Extension\LogExtension::class, LogExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new LogExtension();

diff --git a/pkg/enqueue/Tests/Client/ConsumptionExtension/SetRouterPropertiesExtensionTest.php b/pkg/enqueue/Tests/Client/ConsumptionExtension/SetRouterPropertiesExtensionTest.php
@@ -27,6 +27,9 @@ public function testShouldImplementMessageReceivedExtensionInterface()
         $this->assertClassImplements(MessageReceivedExtensionInterface::class, SetRouterPropertiesExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new SetRouterPropertiesExtension($this->createDriverMock());

diff --git a/pkg/enqueue/Tests/Client/ConsumptionExtension/SetupBrokerExtensionTest.php b/pkg/enqueue/Tests/Client/ConsumptionExtension/SetupBrokerExtensionTest.php
@@ -21,6 +21,9 @@ public function testShouldImplementStartExtensionInterface()
         $this->assertClassImplements(StartExtensionInterface::class, SetupBrokerExtension::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new SetupBrokerExtension($this->createDriverMock());

diff --git a/pkg/enqueue/Tests/Client/DelegateProcessorTest.php b/pkg/enqueue/Tests/Client/DelegateProcessorTest.php
@@ -13,6 +13,9 @@
 
 class DelegateProcessorTest extends TestCase
 {
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new DelegateProcessor($this->createProcessorRegistryMock());

diff --git a/pkg/enqueue/Tests/Client/DriverFactoryTest.php b/pkg/enqueue/Tests/Client/DriverFactoryTest.php
@@ -61,6 +61,9 @@ public function testShouldBeFinal()
         $this->assertTrue($rc->isFinal());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithoutAnyArguments()
     {
         new DriverFactory();

diff --git a/pkg/enqueue/Tests/Client/DriverPreSendTest.php b/pkg/enqueue/Tests/Client/DriverPreSendTest.php
@@ -19,6 +19,9 @@ public function testShouldBeFinal()
         self::assertClassFinal(DriverPreSend::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExpectedArguments()
     {
         new DriverPreSend(

diff --git a/pkg/enqueue/Tests/Client/Extension/PrepareBodyExtensionTest.php b/pkg/enqueue/Tests/Client/Extension/PrepareBodyExtensionTest.php
@@ -22,6 +22,9 @@ public function testShouldImplementExtensionInterface()
         $this->assertTrue($rc->implementsInterface(PreSendCommandExtensionInterface::class));
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldConstructedWithoutAnyArguments()
     {
         new PrepareBodyExtension();

diff --git a/pkg/enqueue/Tests/Client/PostSendTest.php b/pkg/enqueue/Tests/Client/PostSendTest.php
@@ -21,6 +21,9 @@ public function testShouldBeFinal()
         self::assertClassFinal(PostSend::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExpectedArguments()
     {
         new PostSend(

diff --git a/pkg/enqueue/Tests/Client/PreSendTest.php b/pkg/enqueue/Tests/Client/PreSendTest.php
@@ -18,6 +18,9 @@ public function testShouldBeFinal()
         self::assertClassFinal(PreSend::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithExpectedArguments()
     {
         new PreSend(

diff --git a/pkg/enqueue/Tests/Client/ProducerTest.php b/pkg/enqueue/Tests/Client/ProducerTest.php
@@ -24,11 +24,17 @@ public function testShouldBeFinal()
         self::assertClassFinal(Producer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRequiredArguments()
     {
         new Producer($this->createDriverMock(), $this->createRpcFactoryMock());
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithOptionalArguments()
     {
         new Producer(

diff --git a/pkg/enqueue/Tests/Client/SpoolProducerTest.php b/pkg/enqueue/Tests/Client/SpoolProducerTest.php
@@ -18,6 +18,9 @@ public function testShouldImplementProducerInterface()
         self::assertClassImplements(ProducerInterface::class, SpoolProducer::class);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCouldBeConstructedWithRealProducer()
     {
         new SpoolProducer($this->createProducerMock());