Fix compatibility with PHP 8.0

php-imagine · Sep 13, 2020 · e68b92b · e68b92b
1 parent 3db069b
commit e68b92b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -107,6 +107,11 @@ matrix:
       php: '7.4'
       env:
         - IMAGINE_DRIVER: all
+    -
+      name: Test with PHP 8.0 (all drivers)
+      php: '8.0snapshot'
+      env:
+        - IMAGINE_DRIVER: all
     -
       name: Test with PHP nightly (all drivers)
       php: nightly

diff --git a/src/Gd/Imagine.php b/src/Gd/Imagine.php
@@ -91,7 +91,7 @@ public function open($path)
 
         $resource = $this->createImageFromString($data);
 
-        if (!\is_resource($resource)) {
+        if (!$resource instanceof \GdImage && !\is_resource($resource)) {
             throw new RuntimeException(sprintf('Unable to open image %s', $path));
         }
 
@@ -210,7 +210,7 @@ private function doLoad($string, MetadataBag $metadata)
     {
         $resource = $this->createImageFromString($string);
 
-        if (!\is_resource($resource)) {
+        if (!$resource instanceof \GdImage && !\is_resource($resource)) {
             throw new RuntimeException('An image could not be created from the given input');
         }