Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support resize of animated gifs with imagick #348

Closed
wants to merge 3 commits into from

Conversation

plandolt
Copy link
Contributor

support of resizing images with multiple layers with imagick.

feedback very welcome!

@romainneutron
Copy link
Collaborator

Hi @scuben ! Thank for your work, and sorry for the delay.
Could you add a unit test?

@armatronic
Copy link
Contributor

Hi @scuben and @romainneutron, I've added a pull request against this branch which (I hope!) covers this case adequately, you can see it here: plandolt#1

Added unit test for animated GIF resizing
@plandolt
Copy link
Contributor Author

Thanks to @armatronic for adding the tests!

@armatronic
Copy link
Contributor

@romainneutron this should build properly once it's rebased onto develop, since the build issues have been resolved since this PR was opened.

@talbotseb
Copy link

Any idea what still needs to be done for this PR to be merged ?

@armatronic
Copy link
Contributor

@talbotseb as far as I know only the CI checks were failing, I've been using this in production for a while now.

@trsteel88
Copy link

@romainneutron this appears to work. Any update on when this will be merged.

Fyi, the casing is incorrect for 2 methods in the code. It should be "coalesceImages" and "deconstructImages"

@trsteel88
Copy link

@scuben, you might want to fix that method casing btw.

@dupuchba
Copy link

It would be great to get this implemented, can someone re-launch the build ?

@burzum
Copy link
Contributor

burzum commented Jan 6, 2017

@dupuchba I would like to but I can't. :( @avalanche123 can you?

@mlocati
Copy link
Collaborator

mlocati commented Aug 28, 2018

Included in #481 (that was already merged).

@mlocati mlocati closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants