-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support resize of animated gifs with imagick #348
Conversation
Hi @scuben ! Thank for your work, and sorry for the delay. |
Hi @scuben and @romainneutron, I've added a pull request against this branch which (I hope!) covers this case adequately, you can see it here: plandolt#1 |
Added unit test for animated GIF resizing
Thanks to @armatronic for adding the tests! |
@romainneutron this should build properly once it's rebased onto develop, since the build issues have been resolved since this PR was opened. |
Any idea what still needs to be done for this PR to be merged ? |
@talbotseb as far as I know only the CI checks were failing, I've been using this in production for a while now. |
@romainneutron this appears to work. Any update on when this will be merged. Fyi, the casing is incorrect for 2 methods in the code. It should be "coalesceImages" and "deconstructImages" |
@scuben, you might want to fix that method casing btw. |
It would be great to get this implemented, can someone re-launch the build ? |
@dupuchba I would like to but I can't. :( @avalanche123 can you? |
Included in #481 (that was already merged). |
support of resizing images with multiple layers with imagick.
feedback very welcome!