Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lvalue required as left operand of assignment GC_REFCOUNT(&le) = 1; #385

Closed
tekintian opened this issue Mar 15, 2018 · 4 comments
Closed
Milestone

Comments

@tekintian
Copy link

when build with the latest php version https://github.com/php/php-src .

error: lvalue required as left operand of assignment

php_memcached.c . line 1301:

GC_REFCOUNT(&le) = 1;

php_memcached_session.c:379:20: error: lvalue required as left operand of assignment
GC_REFCOUNT(&le) = 1;
^
make: *** [php_memcached_session.lo] Error 1


/tmp/php-memcached-master/php_memcached_session.c: In function 'ps_open_memcached':
/tmp/php-memcached-master/php_memcached_session.c:379:20: error: lvalue required as left operand of assignment
GC_REFCOUNT(&le) = 1;
^
make: *** [php_memcached_session.lo] Error 1
Makefile:202: recipe for target 'php_memcached_session.lo' failed

@sodabrew
Copy link
Contributor

Was this problem resolved? Is this something I'll need to handle for an upcoming 7.x release?

@tekintian
Copy link
Author

tekintian commented Mar 15, 2018

I have found my issue is similar this #385,
And I have just delete this line " GC_REFCOUNT(&le) = 1; " in php_memcached_session.c and php_memcached.c

build it sucess

Here is the php-7.3-dev for docker https://hub.docker.com/r/tekintian/php/ with php-memcached-dev

@tekintian tekintian reopened this Mar 15, 2018
@sodabrew sodabrew added this to the 3.1.0 milestone Mar 16, 2018
@sodabrew
Copy link
Contributor

sodabrew commented Mar 29, 2018

Found it, this is a documented change in the API for PHP 7.3: https://github.com/php/php-src/blob/master/UPGRADING.INTERNALS#L78

Workaround suggested here: https://cismon.net/2018/02/06/Changes-of-Zend-API-in-PHP-7.3/

@tekintian
Copy link
Author

That's great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants