Log cause when memcached error occurs #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log the actual Memcached error when an warning is triggered, to facilitate troubleshooting.
|
Hi! Sorry for the very long delay. This looks like a great idea. Could you rebase this onto current master? |
|
I've just merged #301 that is very similar to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more detailed error logging when a Memcached error occurs.
While this doesn't always pinpoint the exact error cause (if there are retries used within libmemcached, it only provides the last error), it can help in understanding what's going on.
We've been using this patch in software we use and distribute, and it's been running just fine so far.