Add INI setting to choose session consistent hash (ketama or ketama_weighted) #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodabrew
commented
Apr 3, 2018
| @@ -202,7 +196,7 @@ zend_bool s_configure_from_ini_values(memcached_st *memc, zend_bool silent) | |||
| } | |||
|
|
|||
| if (MEMC_SESS_INI(consistent_hash_enabled)) { | |||
| check_set_behavior(MEMCACHED_BEHAVIOR_KETAMA, 1); | |||
| check_set_behavior(MEMC_SESS_INI(consistent_hash_type), 1); | |||
There was a problem hiding this comment.
For some reason, the value of this macro is a randomly large number, when is should be "3" or "4". I haven't sorted out why it's not coming up correctly. printf in the OnUpdateConsistentHash function shows the expected value is set.
There was a problem hiding this comment.
Figured out that I was calling OnUpdateString with the integer field as the target, so the value was the actual pointer value to the string. Added an extra field to hold the string value, and a different field to hold the parsed integer value. Same pattern as the compression type INI setting.
sodabrew
force-pushed
the
session-ketama-type
branch
from
9f1fac7
to
005bb2e
Compare
sodabrew
added a commit
that referenced
this pull request
Apr 9, 2018
…eighted) (#392) Provides a new INI option to select the same consistent hash behavior as older versions of php-memcached, to aid in migration from PHP 5.x to PHP 7.x. When `memcached_sess_consistent_hash_type` is set to `ketama` or `ketama_weighted`, that sets either MEMCACHED_BEHAVIOR_KETAMA or MEMCACHED_BEHAVIOR_KETAMA_WEIGHTED, respectively. Resolves #344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #344