Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configure.ac to Git ignored files #405

Merged
merged 1 commit into from
Sep 1, 2018

Conversation

petk
Copy link
Contributor

@petk petk commented Jul 2, 2018

The configure.ac is used since PHP 7.2 and the updated build system instead of the old configure.in file which is still used in PHP 7.1 and lower versions.

These files are generated during the phpize...

Thank you.

The configure.ac is used since PHP 7.2 and the updated build system
instead of the old configure.in file which is still used in PHP 7.1 and
lower versions.
@sodabrew
Copy link
Contributor

How does this impact PHP 7.0 and 7.1 though?

@petk
Copy link
Contributor Author

petk commented Jul 21, 2018

If the phpize script is a part of the PHP 7.1 or 7.0 installation there will be configure.in file generated from the PHP source code as a part of the old autotools files. If the phpize script is from PHP 7.2 or above there will be the new configure.ac generated. Having these files gitignored is useful when developing the extension. So, that's why adding at least configure.ac is useful... and until PHP 7.1 will be supported also the configure.in.

@sodabrew sodabrew merged commit 58b299e into php-memcached-dev:master Sep 1, 2018
@sodabrew
Copy link
Contributor

sodabrew commented Sep 1, 2018

Took me a third look to realize what you meant. I took the liberty to update the commit message for my own clarity. Thank for this contribution!

@sodabrew sodabrew added this to the 3.1.0 milestone Sep 1, 2018
@petk petk deleted the patch-gitignore branch September 1, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants