Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows msgpack support #518

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Windows msgpack support #518

merged 2 commits into from
Aug 30, 2022

Conversation

lifenglsf
Copy link
Contributor

No description provided.

@sodabrew
Copy link
Contributor

In this PR, I'm only seeing an enable flag in the build flags, but not any code that directly uses the msgpack encoding method on object values.

@lifenglsf
Copy link
Contributor Author

In this PR, I'm only seeing an enable flag in the build flags, but not any code that directly uses the msgpack encoding method on object values.

Yes,just enable flag.msgpack serializer support was implemented a few years ago
image

@sodabrew
Copy link
Contributor

Oh, got it - this is in config.w32 to match the same variables in config.m4. Merging!

@sodabrew sodabrew merged commit 3ff7436 into php-memcached-dev:master Aug 30, 2022
m6w6 added a commit that referenced this pull request Sep 26, 2024
- Add #515 option to locally enforce payload size limit
- Add #539 zstd support
- Add #540 compression_level option
- Mark password as a sensitive param for PHP 8.2
- Fix Windows PHP 8 compatibility
- Fix #518 Windows msgpack support
- Fix #522 signed integer overflow
- Fix #523 incorrect PHP reflection type for Memcached::cas $cas_token
- Fix #546 don't check key automatically, unless client-side verify_key is enabled
- Fix #555 incompatible pointer types (32-bit)
m6w6 added a commit that referenced this pull request Oct 4, 2024
    - Add #515 option to locally enforce payload size limit
    - Add #539 zstd support
    - Add #540 compression_level option
    - Mark password as a sensitive param for PHP 8.2
    - Fix Windows PHP 8 compatibility
    - Fix #518 Windows msgpack support
    - Fix #522 signed integer overflow
    - Fix #523 incorrect PHP reflection type for Memcached::cas $cas_token
    - Fix #546 don't check key automatically, unless client-side verify_key is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants