Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove phpcs-fixer --diff-fomat option #163

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

gimler
Copy link
Contributor

@gimler gimler commented Jan 26, 2022

the option --diff-format no longer exist see also
PHP-CS-Fixer/PHP-CS-Fixer#3384

@bocharsky-bw
Copy link
Member

Good catch! Could you make PHP CS Fixer green in this PR? Now it says:

Configuration file .php_cs is outdated, rename to .php-cs-fixer.php.

@bocharsky-bw
Copy link
Member

bocharsky-bw commented Jan 26, 2022

I think we should run Fixer with --diff option so we see the actual diff in the output too, could you add that option?

@bocharsky-bw
Copy link
Member

Great, thank you for fixing it!

@bocharsky-bw bocharsky-bw merged commit ebe542b into php-translation:master Jan 26, 2022
@gimler gimler deleted the patch-2 branch January 26, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants