feat: Twig\Node\Expression\FilterExpression use attribute instate of … #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocharsky-bw
reviewed
Oct 2, 2024
| @@ -83,7 +83,7 @@ private function extractContextFromJoinedFilters(): array | |||
| if (!$this->stack[$i] instanceof FilterExpression) { | |||
| break; | |||
| } | |||
| $name = $this->stack[$i]->getNode('filter')->getAttribute('value'); | |||
| $name = $this->stack[$i]->getAttribute('twig_callable')->getName(); | |||
There was a problem hiding this comment.
A BC question, will it work for v2? I see we allow "twig/twig": "^2.0 || ^3.0". Or should we bump the twig/twig dependency to allow only v3?
There was a problem hiding this comment.
I am Not shure but it should. I checked the source code of booth branches.
I can open another pr to fix the cs, because the problems are not related to the changes of this pr.
There was a problem hiding this comment.
Please, feel free to open a new PR to fix SA tools fails!
bocharsky-bw
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deprecation warning
see https://twig.symfony.com/doc/3.x/deprecated.html#nodes