Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony 7 #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vitsadecky
Copy link

updated composer

allow symfony 7
@rsereir
Copy link

rsereir commented May 30, 2024

please a merge here :)

@p-palma
Copy link

p-palma commented Jun 14, 2024

any news about this ?

@damienlagae
Copy link
Contributor

@welcoMattic @Nyholm any news about this ?

@rsereir
Copy link

rsereir commented Dec 5, 2024

Hello !

This package seems deprecated, use the official adapter maintained by symfony here: https://github.com/symfony/loco-translation-provider instead

@damienlagae
Copy link
Contributor

@rsereir I've tried it, but the behavior isn't the same.
With this adapter, when I edit the translation in the profiler, it's automatically synchronized with loco.
With the Symfony provider:

  • You have to pull & push to synchronize translations.
  • The keys (id) change, so you have to resynchronize all the translations, and you get Loco timeouts because it does this translation by translation.
  • With 3 locales, it will make 4 calls, create the asset (1 call), add the translations (1 call per locale => 3 calls).
  • With a translation file of over 600 assets in 3 languages, they can't even create all the assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants