For better performance, Loader should send If-Modified-Since headers when downloading TUF metadata, and read unmodified data from persistent storage #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedbow
reviewed
Oct 25, 2023
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we have a big performance problem, which is that we always download TUF metadata from the server, even if we already have the most up-to-date version of it in persistent storage. That's real bad.
We need to fix this by sending an
If-Modified-Sinceheader with these requests. If the server supports them, it should reply to requests for unchanged metadata with304 Not Modified, which should be our cue to load the data from persistent storage.