Fixed #9165: strtotime translates a date-time with DST/non-DST hour d…

…ifferently based on default timezone
php · Sep 14, 2022 · e5b4624 · e5b4624
1 parent 4a52022
commit e5b4624
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/NEWS b/NEWS
@@ -10,6 +10,10 @@ PHP                                                                        NEWS
   . Fixed bug GH-9447 (Invalid class FQN emitted by AST dump for new and class
     constants in constant expressions). (ilutov)
 
+- Date:
+  . Fixed bug GH-9165 (strtotime translates a date-time with DST/non-DST hour
+    differently based on default timezone). (Derick)
+
 - DOM:
   . Fixed bug #79451 (DOMDocument->replaceChild on doctype causes double free).
     (Nathan Freeman)

diff --git a/ext/date/tests/gh9165.phpt b/ext/date/tests/gh9165.phpt
@@ -0,0 +1,21 @@
+--TEST--
+GH-9165 (strtotime translates a date-time with DST/non-DST hour differently based on default timezone)
+--FILE--
+<?php
+date_default_timezone_set('America/Lower_Princes');
+echo strtotime("2018-10-28 01:00:00 Europe/London") . PHP_EOL;
+
+date_default_timezone_set('Europe/London');
+echo strtotime("2018-10-28 01:00:00 Europe/London"). PHP_EOL;
+
+date_default_timezone_set('America/Lower_Princes');
+echo strtotime("2018-10-28 04:00:00 Europe/London") . PHP_EOL;
+
+date_default_timezone_set('Europe/London');
+echo strtotime("2018-10-28 04:00:00 Europe/London"). PHP_EOL;
+?>
+--EXPECT--
+1540684800
+1540684800
+1540699200
+1540699200