Meaningful data type for _parameter_reference's "required" field #15

paulbarbu · 2012-03-20T19:17:17Z

Hi.

The aim of this patch is to fix a problem related to the _parameter_reference
structure and its required field.

The required field, until now, stored how many required parameters the function, it belongs to, has. I think this is rather problematic because it's a feature of the function to know how many required parameters it has, not of the parameter itself. The parameter should only say if it's required or optional (among other unrelated things).

Also storing the function's number of required parameters in every parameter was redundant since the _zend_function structure already has that information. And storing the same value (number of required parameters) across multiple variables is inefficient and could lead to inconsistencies.

So I tried to solve this problem by declaring the required field as zend_bool (see 7fe93ca66dd806a197).

While working on this I noticed some inconsistency between a comment and the code, bb59a5f5256df4d2e6.

I also updated the related reflection tests and everything seems ok (59fa4989f2ebb8d0).

While updating the tests I noticed a duplicate so I deleted it, see f613f01157abfc495.

Finally I thought var_dump() calls on a ReflectionParameter must be consistent with echo and print so I came up with db3c26b4e62361a.

PS:
You can assign the above stated problem with the following analogy.
A vehicle must know about its number of required or optional (in case of flats) wheels (parameters), the wheel itself should not know how many of it it takes to assemble the vehicle(the function) in order to run.
It only says that it's required when it's assembled on the vehicle and optional when serving as a back up wheel.

paulbarbu · 2012-03-20T20:02:06Z

I added that to be consistent with echo or print, they already printed information about the "requiredness" of a parameter (because of __toString()) while var_dump() did not.

paulbarbu · 2012-03-20T21:04:24Z

Done.
Out of curiosity, why are you saying it's odd?

nikic · 2012-03-20T21:16:56Z

@dsp I'm not really sure that it's @PaulLik's fault. I think this is GitHub messing with the tabs. As you can see all tabs were converted to two whitespaces in the PR diff.

paulbarbu · 2012-03-20T21:32:42Z

Oh, you're talking about the indentation?
On my machine everything is OK, I use (g)vim to program so the mode lines did their job.

dsp · 2012-03-27T17:58:23Z

bump, did anyone look into it yet?

nikic · 2012-03-27T18:46:06Z

I agree with @smalyshev that a public required property should not be exposed. All other info like whether it is a by-ref param or which typehint and default it has, aren't exposed as properties either. So that would be inconsistent.

paulbarbu · 2012-03-27T19:21:32Z

Well, OK, but then why _parameter_string still "displays" whether that's a required parameter or not?

From my POV it's an inconsistency var_dump vs print/echo.

Anyway, waiting for advice.

nikic · 2012-03-27T21:22:47Z

@PaulLik If you want to provide this info for var_dump and print_r a better way would be to register a get_debug_info object handler. It allows you to create a HT with pseudo-properties to be shown in var_dump output. Here is an example of what is done for closures: http://lxr.php.net/opengrok/xref/PHP_TRUNK/Zend/zend_closures.c#zend_closure_get_debug_info

paulbarbu · 2012-03-28T19:36:03Z

Oh, it makes sense now.
I think I understand what I have to do in order to provide that information [1] and why my reflection_update_property way to solve the var_dump()'s output was inappropriate.

Thank you.

[1] I need to add a debug_info field to either _parameter_reference or to reflection_object, tough I'm not sure about this.

I'll update my patch once I get some free time.

nikic · 2012-03-28T19:40:54Z

@PaulLik For now I'd just remove that part of the change so that the rest can be merged :) The debug handler(s) can always be added later :)

paulbarbu · 2012-03-29T11:40:14Z

Done.
I reverted the public property thing and re-run the tests, everything seems OK.

paulbarbu · 2012-04-02T19:46:00Z

Bump.

smalyshev · 2012-04-03T07:50:41Z

ext/reflection/tests/025.phpt

-ReflectionFunction basic tests
--SKIPIF--
-<?php extension_loaded('reflection') or die('skip'); ?>
+ReflectionExtension::info()


What is the purpose of this line?

smalyshev · 2012-04-03T07:52:35Z

I'm not sure I understand - why you moved test 26 into test 25? Was something wrong with test 25?

paulbarbu · 2012-04-04T14:15:14Z

Hmmm, I must have done something wrong somewhere because when I checked those two tests were the same.
I'm sorry for this mistake.

Maybe I should close this issue and post a new one with the good commits?

reeze · 2012-04-05T02:38:33Z

@PaulLik maybe we can rebase this pull branch ?

nikic · 2012-04-05T09:28:54Z

ext/reflection/php_reflection.c

+		}
+		else{
+			required = 1;
+		}


Btw, this could also be replaced by required = (i >= fptr->common.required_num_args) ? 0 : 1;.

If we want to bikeshed this, the proper suggestion would be required = (i < fptr->common.required_num_args).

…type (zend_bool) for its purpose

paulbarbu · 2012-04-05T15:51:41Z

@nikic updated to use the ternary operator.
@reeze rebased.

paulbarbu · 2012-04-07T15:09:25Z

@cataphract Well, come on...

smalyshev · 2013-08-04T23:23:39Z

ext/reflection/php_reflection.c

 	if (arg_info->name) {
 		ZVAL_STRINGL(name, arg_info->name, arg_info->name_len, 1);
 	} else {
 		ZVAL_NULL(name);
 	}
+
+	ZVAL_BOOL(req, required);


why req is created here? doesn't look like it is going anywhere.

raven0034 · 2016-11-09T17:39:40Z

is this ever going to get closed?

php-pulls · 2016-12-26T18:43:57Z

Comment on behalf of pollita at php.net:

Updated and merged e52d2b8

The following opcodes would be generated: ... BB1: 0003 JMP BB3 BB2: 0004 INIT_FCALL 1 96 string("chr") 0005 #10.T3 [long] = SR #3.CV0($int) [long] #7.CV2($i) ... 0006 #11.T4 [long] RANGE[0..127] = BW_AND #10.T3 [long] ... 0007 #12.T3 [long] RANGE[128..255] = BW_OR #11.T4 [long] ... 0008 SEND_VAL #12.T3 [long] RANGE[128..255] 1 0009 #13.V3 [ref, rc1, rcn, any] = DO_ICALL 0010 ASSIGN_OP (CONCAT) #6.CV1($out) [rc1, rcn, string] 0011 ADD #7.CV2($i)... int(7) #7.CV2($i) ... -> #15.CV2($i) ... BB3: 0012 #8.T4 [long] = SR #3.CV0($int) #7.CV2($i) [long, double] 0013 #9.T3 [bool] RANGE[0..1] = IS_SMALLER int(128) #8.T4 0014 JMPNZ #9.T3 [bool] RANGE[0..1] BB2 ... Main changes are: 1. SR opcode covers new path in function zend_jit_long_math_helper(). 2. BW_AND and BW_OR opcodes are supported. See macro LONG_OP. 3. Function zend_jit_concat_helper() is added to support ASSIGN_OP opcode. Speficically, CONCAT and FAST_CONCAT is supported for statements "$out .= ...". 4. New path is covered in function zend_jit_cmp_long_long() by IS_SMALLER opcode. 5. New path is covered in macros ZVAL_PTR_DTOR and ZVAL_DTOR_FUNC when leaving.

even without sanitizers, it is reproducible but with the following ``` <?php $g = gmp_init(256); var_dump(gmp_pow($g, PHP_INT_MAX)); ``` we get this ``` AddressSanitizer:DEADLYSIGNAL ================================================================= ==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0) #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44 #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26 php#2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) php#3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) php#4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) php#5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) php#6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286 php#7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312 php#8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075 php#9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439 php#10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842 php#11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578 php#12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964 php#13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334 php#14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 php#15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360 php#16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation ==286922==ABORTING ```

even without sanitizers, it is reproducible but with the following ``` <?php $g = gmp_init(256); var_dump(gmp_pow($g, PHP_INT_MAX)); ``` we get this ``` AddressSanitizer:DEADLYSIGNAL ================================================================= ==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0) #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44 #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26 #2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) #3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) #4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) #5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) #6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286 #7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312 #8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075 #9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439 #10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842 #11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578 #12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964 #13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334 #14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 #15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360 #16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation ==286922==ABORTING ```

even without sanitizers, it is reproducible but with the following ``` <?php $g = gmp_init(256); var_dump(gmp_pow($g, PHP_INT_MAX)); ``` we get this ``` AddressSanitizer:DEADLYSIGNAL ================================================================= ==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0) #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44 #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26 php#2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) php#3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) php#4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) php#5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) php#6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286 php#7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312 php#8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075 php#9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439 php#10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842 php#11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578 php#12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964 php#13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334 php#14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 php#15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360 php#16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation ==286922==ABORTING ```

even without sanitizers, it is reproducible but with the following ``` <?php $g = gmp_init(256); var_dump(gmp_pow($g, PHP_INT_MAX)); ``` we get this ``` AddressSanitizer:DEADLYSIGNAL ================================================================= ==286922==ERROR: AddressSanitizer: FPE on unknown address 0x03e8000460ca (pc 0x7faf6c69de5c bp 0x400000000000004 sp 0x7ffe9843c740 T0) #0 0x7faf6c69de5c in __pthread_kill_implementation nptl/pthread_kill.c:44 #1 0x7faf6c649c81 in __GI_raise ../sysdeps/posix/raise.c:26 #2 0x7faf6db9386c in __gmp_exception (/lib/x86_64-linux-gnu/libgmp.so.10+0xd86c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) #3 0x7faf6db938d3 in __gmp_overflow_in_mpz (/lib/x86_64-linux-gnu/libgmp.so.10+0xd8d3) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) #4 0x7faf6dbac95c in __gmpz_realloc (/lib/x86_64-linux-gnu/libgmp.so.10+0x2695c) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) #5 0x7faf6dba9038 in __gmpz_n_pow_ui (/lib/x86_64-linux-gnu/libgmp.so.10+0x23038) (BuildId: 1af68a49fe041a5bb48a2915c3d47541f713bb38) #6 0x5565ae1ccd9f in zif_gmp_pow /home/dcarlier/Contribs/php-src/ext/gmp/gmp.c:1286 #7 0x5565aee96ea9 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:1312 #8 0x5565af144320 in execute_ex /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:56075 #9 0x5565af160f07 in zend_execute /home/dcarlier/Contribs/php-src/Zend/zend_vm_execute.h:60439 #10 0x5565aed6fafe in zend_execute_scripts /home/dcarlier/Contribs/php-src/Zend/zend.c:1842 #11 0x5565aeae70a8 in php_execute_script /home/dcarlier/Contribs/php-src/main/main.c:2578 #12 0x5565af532f4e in do_cli /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:964 #13 0x5565af535877 in main /home/dcarlier/Contribs/php-src/sapi/cli/php_cli.c:1334 #14 0x7faf6c633d67 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 #15 0x7faf6c633e24 in __libc_start_main_impl ../csu/libc-start.c:360 #16 0x5565adc04040 in _start (/home/dcarlier/Contribs/php-src/sapi/cli/php+0x2604040) (BuildId: 949049955bdf8b7197390b1978a1dfc3ef6fdf38) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: FPE nptl/pthread_kill.c:44 in __pthread_kill_implementation ==286922==ABORTING ``` close GH-16384

smalyshev reviewed Apr 3, 2012
View reviewed changes

nikic reviewed Apr 5, 2012
View reviewed changes

Barbu Paul - Gheorghe added 2 commits April 5, 2012 18:46

fixed comment about the function's retval

086c10e

changed _parameter_reference's 'required' field to a meaningful data …

2596b3b

…type (zend_bool) for its purpose

Draal mentioned this pull request Apr 7, 2013

Exif crash on unknown encoding was fixed #293

Closed

smalyshev reviewed Aug 4, 2013
View reviewed changes

dstogov referenced this pull request Apr 17, 2015

Added GC checks and improvements

276080e

php-pulls closed this Dec 26, 2016

schwindy mentioned this pull request Mar 31, 2017

"zend_mm_heap corrupted #<$id>" | Added Error ID to Error Message #2445

Closed

AlexeyZamorov mentioned this pull request Aug 26, 2021

Update interface.c #7376

Closed

0xhacking mentioned this pull request Mar 17, 2022

Opcache enable Crash Core dump #8209

Closed

ffang-imvu mentioned this pull request Jun 15, 2022

Segmentation faults in 8.1.5 with opcache enabled #8797

Closed

gregherrell mentioned this pull request Aug 17, 2022

JIT segmentation fault in PHP 8.1 #7817

Open

pfrappe mentioned this pull request Jan 28, 2023

Apache Segmentation fault (11) disappears after print_r on a variable. can't understand... #10430

Open

dunglas mentioned this pull request Sep 17, 2023

Segmentation fault when building Symfony cache on Alpine #12234

Closed

jcencekibm mentioned this pull request Apr 1, 2024

Incorrect PHP_STREAM_OPTION_CHECK_LIVENESS case in ext/openssl/xp_ssl.c - causing use of dead socket #13860

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meaningful data type for _parameter_reference's "required" field #15

Meaningful data type for _parameter_reference's "required" field #15

paulbarbu commented Mar 20, 2012

paulbarbu commented Mar 20, 2012

paulbarbu commented Mar 20, 2012

nikic commented Mar 20, 2012

paulbarbu commented Mar 20, 2012

dsp commented Mar 27, 2012

nikic commented Mar 27, 2012

paulbarbu commented Mar 27, 2012

nikic commented Mar 27, 2012

paulbarbu commented Mar 28, 2012

nikic commented Mar 28, 2012

paulbarbu commented Mar 29, 2012

paulbarbu commented Apr 2, 2012

smalyshev Apr 3, 2012

smalyshev commented Apr 3, 2012

paulbarbu commented Apr 4, 2012

reeze commented Apr 5, 2012

nikic Apr 5, 2012

cataphract Apr 7, 2012

paulbarbu commented Apr 5, 2012

paulbarbu commented Apr 7, 2012

smalyshev Aug 4, 2013

raven0034 commented Nov 9, 2016

php-pulls commented Dec 26, 2016

Meaningful data type for _parameter_reference's "required" field #15

Meaningful data type for _parameter_reference's "required" field #15

Conversation

paulbarbu commented Mar 20, 2012

paulbarbu commented Mar 20, 2012

paulbarbu commented Mar 20, 2012

nikic commented Mar 20, 2012

paulbarbu commented Mar 20, 2012

dsp commented Mar 27, 2012

nikic commented Mar 27, 2012

paulbarbu commented Mar 27, 2012

nikic commented Mar 27, 2012

paulbarbu commented Mar 28, 2012

nikic commented Mar 28, 2012

paulbarbu commented Mar 29, 2012

paulbarbu commented Apr 2, 2012

smalyshev Apr 3, 2012

Choose a reason for hiding this comment

smalyshev commented Apr 3, 2012

paulbarbu commented Apr 4, 2012

reeze commented Apr 5, 2012

nikic Apr 5, 2012

Choose a reason for hiding this comment

cataphract Apr 7, 2012

Choose a reason for hiding this comment

paulbarbu commented Apr 5, 2012

paulbarbu commented Apr 7, 2012

smalyshev Aug 4, 2013

Choose a reason for hiding this comment

raven0034 commented Nov 9, 2016

php-pulls commented Dec 26, 2016