Fix GH-9139: Allow FFI in opcache.preload when opcache.preload_user=root #9473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opcache.preload
can not be used for FFI preloading when running as root, because of a chain of causes:opcache.preload
requiresopcache.preload_user
when running as rootopcache.preload_user
is defined, because the preloading happens in a sub-process in this caseIt is not strictly necessary to preload in a sub-process when
opcache.preload_user
is the current user, because we are not going to change the uid of the process.This PR skips the fork() when
opcache.preload_user
is the current user, thus allowing FFI inopcache.preload
when running as root, as long asopcache.preload_user=root
.Although running as root is not recommended, it is common practice with docker containers. This change also allows to have at least one CI pipeline running as root.
Fixes #9139
Most changes are whitespaces.