Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid PHP Warning when parsing empty list item #451

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Avoid PHP Warning when parsing empty list item #451

merged 1 commit into from
Jul 5, 2023

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Jul 4, 2023 •
edited
Loading

Relates to doctrine/orm#10812

@greg0ire greg0ire mentioned this pull request Jul 4, 2023
Merged
@greg0ire greg0ire force-pushed the avoid-warning branch 3 times, most recently from 5fb69b0 to 94b4c31 Compare July 4, 2023 09:43
jaapio
jaapio approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this addition.

@jaapio jaapio enabled auto-merge July 5, 2023 06:20
@greg0ire @jaapio
Improve handling of empty lists
a661a18 
With this change users will get a psr/log warning instead of the PHP
Warning they were getting before.
@jaapio jaapio merged commit 2ad5df9 into phpDocumentor:main Jul 5, 2023
@greg0ire greg0ire deleted the avoid-warning branch July 5, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapio jaapio jaapio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @jaapio