-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AssociationMapping type #355
Conversation
I updated the type following the PR doctrine/orm#9965 This seems pretty annoying having to copy paste all changes from orm here. I think the best would be to "fix" phpstan in order to be able to understand the type defined in the original class, even if it was re-declared in the stub. (Especially here because the type are not used in the stub) I reproduce the error here: sonata-project/EntityAuditBundle#503 |
I found the issue. As soon as the stub has a some class phpdoc (I reproduced with |
Thank you. |
You're welcome. If you have time for a release, it would help me a lot until a solution is found for phpstan/phpstan#7755 :) |
The build is failing and I need to investigate it - if it's a bug or if it's a consequence of your change and I can remove some asserts. |
I see. I'll tried to take a look. For the record my PR just copied-pasted the types from doctrine/orm. So if there is an error in the type, I'll need to do the pr on doctrine/orm too ^^ |
I just check and it seems you can indeed remove a lot of assert/phpdoc/cast. |
Hi @ondrejmirtes, I was trying the doctrine/orm 2.13.x branch, after the merge of doctrine/orm#9794
And I'm getting a log of
Seems like it's because the type is not defined in the stub. When I modified my vendor, it fixed the issue.