ReadOnlyPropertyRule - check static

phpstan · Sep 29, 2022 · 3e383fc · 3e383fc
1 parent 10ee36c
commit 3e383fc
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/src/Rules/Properties/ReadOnlyPropertyRule.php b/src/Rules/Properties/ReadOnlyPropertyRule.php
@@ -43,6 +43,10 @@ public function processNode(Node $node, Scope $scope): array
 			 $errors[] = RuleErrorBuilder::message('Readonly property cannot have a default value.')->nonIgnorable()->build();
 		}
 
+		if ($node->isStatic()) {
+			$errors[] = RuleErrorBuilder::message('Readonly property cannot be static.')->nonIgnorable()->build();
+		}
+
 		return $errors;
 	}
 

diff --git a/tests/PHPStan/Rules/Properties/ReadOnlyPropertyRuleTest.php b/tests/PHPStan/Rules/Properties/ReadOnlyPropertyRuleTest.php
@@ -49,6 +49,14 @@ public function dataRule(): array
 						'Readonly properties are supported only on PHP 8.1 and later.',
 						16,
 					],
+					[
+						'Readonly properties are supported only on PHP 8.1 and later.',
+						23,
+					],
+					[
+						'Readonly property cannot be static.',
+						23,
+					],
 				],
 			],
 			[
@@ -62,6 +70,10 @@ public function dataRule(): array
 						'Readonly property cannot have a default value.',
 						10,
 					],
+					[
+						'Readonly property cannot be static.',
+						23,
+					],
 				],
 			],
 		];

diff --git a/tests/PHPStan/Rules/Properties/data/read-only-property.php b/tests/PHPStan/Rules/Properties/data/read-only-property.php
@@ -17,3 +17,8 @@ public function __construct(public readonly string $message = '')
 	{
 	}
 }
+
+class StaticReadonlyProperty
+{
+	private readonly static int $foo;
+}
-Original file line number
+Diff line change
@@ Expand Up @@
     	{
     	}
     }
+    class StaticReadonlyProperty
+    {
+    	private readonly static int $foo;
+    }