OptimizedDirectorySourceLocator - fix bug with upper-case Function ke…

…yword
phpstan · Feb 25, 2022 · dbbb721 · dbbb721
1 parent 7110a08
commit dbbb721
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/src/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocator.php b/src/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocator.php
@@ -225,10 +225,11 @@ private function findSymbols(string $file): array
 				}
 				$namespacedName = strtolower(ltrim($namespace . $name, '\\'));
 
-				if ($matches['type'][$i] === 'function') {
+				$lowerType = strtolower($matches['type'][$i]);
+				if ($lowerType === 'function') {
 					$functions[] = $namespacedName;
 				} else {
-					if (strtolower($matches['type'][$i]) === 'enum') {
+					if ($lowerType === 'enum') {
 						$colonPos = strrpos($namespacedName, ':');
 						if (false !== $colonPos) {
 							$namespacedName = substr($namespacedName, 0, $colonPos);

diff --git a/...PHPStan/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocatorTest.php b/...PHPStan/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocatorTest.php
@@ -113,6 +113,11 @@ public function dataFunctionExists(): array
 				'OptimizedDirectory\\get_smarty2',
 				'b.php',
 			],
+			[
+				'OptimizedDirectory\\upperCaseFunction',
+				'OptimizedDirectory\\upperCaseFunction',
+				'b.php',
+			],
 		];
 	}
 

diff --git a/tests/PHPStan/Reflection/BetterReflection/SourceLocator/data/directory/b.php b/tests/PHPStan/Reflection/BetterReflection/SourceLocator/data/directory/b.php
@@ -35,3 +35,8 @@ function & get_smarty2()
 
 	return $smarty;
 }
+
+Function upperCaseFunction()
+{
+
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -35,3 +35,8 @@ function & get_smarty2() @@
     	return $smarty;
     }
+    Function upperCaseFunction()
+    {
+    }