Do not report nonexistent variable passed to by-ref parameter with ch…

…eckImplicitMixed
phpstan · Nov 12, 2024 · f158d5b · f158d5b
1 parent 3447391
commit f158d5b
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/src/Rules/FunctionCallParametersCheck.php b/src/Rules/FunctionCallParametersCheck.php
@@ -313,7 +313,11 @@ public function check(
 
 				if (
 					!$parameter->passedByReference()->createsNewVariable()
-					|| (!$isBuiltin && $this->checkUnresolvableParameterTypes) // bleeding edge only
+					|| (
+						!$isBuiltin
+						&& $this->checkUnresolvableParameterTypes // bleeding edge only
+						&& !$argumentValueType instanceof ErrorType
+					)
 				) {
 					$accepts = $this->ruleLevelHelper->acceptsWithReason($parameterType, $argumentValueType, $scope->isDeclareStrictTypes());
 

diff --git a/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php b/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php
@@ -849,4 +849,12 @@ public function testBug10872(): void
 		$this->analyse([__DIR__ . '/data/bug-10872.php'], []);
 	}
 
+	public function testBug12015(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkExplicitMixed = true;
+		$this->checkImplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-12015.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/bug-12015.php b/tests/PHPStan/Rules/Methods/data/bug-12015.php
@@ -0,0 +1,21 @@
+<?php
+
+namespace Bug12015;
+
+class HelloWorld
+{
+
+	/**
+	 * @param-out int $ref
+	 */
+	public static function passRef(?int &$ref): void
+	{
+		$ref = 1;
+	}
+}
+
+function test(): void
+{
+	HelloWorld::passRef($storeHere);
+	echo $storeHere;
+}