PropertyDescriptor - correctly resolve from reflection whether a prop…

…erty is static or not
phpstan · Oct 18, 2020 · fadb439 · fadb439
1 parent 1893100
commit fadb439
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Rules/Properties/PropertyDescriptor.php b/src/Rules/Properties/PropertyDescriptor.php
@@ -16,7 +16,7 @@ public function describeProperty(PropertyReflection $property, $propertyFetch):
 	{
 		/** @var \PhpParser\Node\Identifier $name */
 		$name = $propertyFetch->name;
-		if ($propertyFetch instanceof \PhpParser\Node\Expr\PropertyFetch) {
+		if (!$property->isStatic()) {
 			return sprintf('Property %s::$%s', $property->getDeclaringClass()->getDisplayName(), $name->name);
 		}
 

diff --git a/tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php b/tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php
@@ -39,7 +39,7 @@ public function testTypesAssignedToProperties(): void
 				37,
 			],
 			[
-				'Static property PropertiesAssignedTypes\Ipsum::$parentStringProperty (string) does not accept int.',
+				'Property PropertiesAssignedTypes\Ipsum::$parentStringProperty (string) does not accept int.',
 				39,
 			],
 			[
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,7 +39,7 @@ public function testTypesAssignedToProperties(): void @@
 ,
     			],
     			[
-    				'Static property PropertiesAssignedTypes\Ipsum::$parentStringProperty (string) does not accept int.',
+    				'Property PropertiesAssignedTypes\Ipsum::$parentStringProperty (string) does not accept int.',
 ,
     			],
     			[
@@ Expand Down @@