Exclude PHPUnit asserts etc. from DynamicCallOnStaticMethodsRule?

[BluePsyduck]

When using PHPUnit, assertions and some other methods are normally called dynamically (e.g. $this->assertSame() or $this->once()), although they are declared as static methods. This of course triggers the DynamicCallOnStaticMethodsRule for all these calls.

According to the author of PHPUnit, it is encouraged to use $this-> instead of self::.

Keeping that in mind the question is: Should the PHPUnit classes (e.g. PHPUnit\Framework\Assert and PHPUnit\Framework\TestCase) be excluded from the DynamicCallOnStaticMethodsRule? (Maybe through a parameter to enable/disable this?)

[mhujer]

From https://phpunit.readthedocs.io/en/7.3/assertions.html#static-vs-non-static-usage-of-assertion-methods

A common question, especially from developers new to PHPUnit, is whether using $this->assertTrue() or self::assertTrue(), for instance, is “the right way” to invoke an assertion. The short answer is: there is no right way. And there is no wrong way, either. It is a matter of personal preference.

[ondrejmirtes]

If you don’t agree with this rule and want to call PHPUnit methods as instance methods, simply put a regexp to ignoreErrors config key.

On Fri, 7 Sep 2018 at 18:18, Martin Hujer ***@***.***> wrote: From https://phpunit.readthedocs.io/en/7.3/assertions.html#static-vs-non-static-usage-of-assertion-methods A common question, especially from developers new to PHPUnit, is whether using $this->assertTrue() or self::assertTrue(), for instance, is “the right way” to invoke an assertion. The short answer is: there is no right way. And there is no wrong way, either. It is a matter of personal preference. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuHd9t-7obaqRe4rHVxxuZMv-y0W8ks5uYpxQgaJpZM4WfGvE> .

-- Ondřej Mirtes

[eugcar]

@ondrejmirtes Could you gently say explicitly how to simply put a regexp to ignoreErrors config key?

[BluePsyduck]

@eugcar In your phpstan.neon configuration file, add the following:

parameters:
  ignoreErrors:
    - '#Dynamic call to static method PHPUnit\\Framework\\.*#'

This will ignore the error for all relevant PHPUnit classes.

[ondrejmirtes]

It's in the README.

[eugcar]

@BluePsyduck @ondrejmirtes Thanks for your support. It works :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.