syslog-ng can fail after a commit #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tar? As far as I know |
|
Moved to #31 for rebase so that patch can pull cleanly into new HEAD. |
kingdonb
pushed a commit
to kingdonb/baseimage-docker
that referenced
this pull request
Apr 30, 2014
/dev/log can't be a file (it's an error)
mpeterson
pushed a commit
to mpeterson/docker-phusion-baseimage
that referenced
this pull request
May 10, 2014
/dev/log can't be a file (it's an error)
FooBarWidget
pushed a commit
that referenced
this pull request
May 12, 2014
kingdonb
pushed a commit
to kingdonb/baseimage-docker
that referenced
this pull request
May 17, 2014
lattwood
pushed a commit
to lattwood/baseimage-docker
that referenced
this pull request
Dec 17, 2015
guedressel
pushed a commit
to protosrc/baseimage-docker
that referenced
this pull request
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You might be bit by this sooner or later, I started diagnostic here: moby/moby#4336
Come to find out that docker's (go's?) implementation of tar will incorrectly preserve named sockets in committed images as empty files. This is only a problem for those who commit images that have already been run once, since syslog-ng doesn't clean up after itself.
It works for most, since the dockerfile does not attempt to start syslog-ng during the build.
I propose adding this kind of change to the front of the syslog-ng runit service script (pull attached):
if [ ! -S /dev/log ]; then rm -f /dev/log; fi