Upgrade to Trusty + Python3 #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of copying over a hardcoded file we just uncomment the correct lines via two simple sed commands.
Ubuntu 14.04 LTS defaults to python3. This required updating both my_init and setuser. Also, my_init referenced the deprecated posixfile module, which was removed in python3. It was not used anyway, so I simply removed the import. For the curious, posixfile was deprecated by fcntl.lockf, which does the same thing, but more portably. https://docs.python.org/2/library/fcntl.html#fcntl.lockf Signed-off-by: Christian Romney <[email protected]>
Signed-off-by: Christian Romney <[email protected]>
|
docker image id is 7d11830f76c2 |
Closed
|
I've created #71 which integrates your changes but however includes contributions made by other persons (so we don't leave the credits out). It also adds things myself that are needed for it to work correctly. |
|
For instance a needed change to syslogng defaults |
|
Let's move to #71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt. Again, applied mpeterson's patch which elegantly enables uni/multiverse and updated Dockerfile to 14.04. Additionally, changed shebang lines in my_init and setuser to use python3 (new default in Trusty), and removed unused, deprecated posixfile import.
Smoke tested locally and pushed to docker index at https://index.docker.io/u/christianromney/baseimage/ for broader testing and acceptance.