Fixed process of building grid #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of previous approach. This might have fixed one or many of: #29, #31, #38 Co-authored-by: Nikolay Nechaev <[email protected]>
…t only squares Co-authored-by: Tanya Kadykova <[email protected]>
…ion similar Co-authored-by: Tanya Kadykova <[email protected]>
Co-authored-by: Tanya Kadykova <[email protected]>
Co-authored-by: Tanya Kadykova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the algorithm of checking if a particle is located on a face (which seems to have fixed the grid creation issues) + minor meta fixes.
Please, confirm, but as far as I can see, this PR fixes #29, fixes #31, fixes #38.
Note that the checks with the Ubuntu 16.04 operating system will fail because GitHub does not any longer provide containers with it. This is already fixed in #55, so I can merge it into this branch as soon as you approve it.