-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SalesInvoice.php #7
Conversation
Updated with all the properties from the documentation
Added all documented properties to SalesInvoice entity
Thanks @bertjuuhh ! |
@stephangroen You're welcome. |
@bertjuuhh That's a bug, which I have just resolved :) Filtering could return a single item or multiple items. We didn't account for that yet. I have made an adjustment, which makes filtering always return a collection of items, with just 1 item in the collection in case of a single item return. This ensures the filter() call will always return the same style of result. See: 9f84d7d |
@stephangroen Awesome, thankyou :) |
@stephangroen Do i still need to put an $item->get after the filter to get the results or am i missing something? |
@bertjuuhh No, $item->filter will return an collection (array) of resulting objects, which you can loop over with a foreach. |
Oke, thank you! |
@stephangroen i found the problem, i was looking up accounts with 'Code' but apparently you need the leading spaces in front of them to get results back. |
@bertjuuhh Yup, they require the leading spaces indeed. This is written somewhere in their docs :) |
Updated with all the properties from the documentation