Extract Division from request @ financialtransaction/Transactions

[WietseWind]

Fix for division number in URL: redundant when filtering on Division eq 1337.

Improved version of fix in pull request 82. Prevents users to use the setDivision method when already filtering for a division ID.

Use case: when not using PHP, but PHP (this class) is still being used (under the hood). This is de case for nodum aPaas when doing something like this:

{% for division in [ 136107, 84319, 84324, 128622, 84927 ] %}
    {% set inkoopboek = api.Exact_Online.getTransactions( 
        "Division eq " ~ division ~ " and FinancialYear eq 2016 and JournalDescription eq 'Inkoopboek'",
        '', 'Date', {} 
    ) %}

    <h3>{{ division }}</h3>
    {{ inkoopboek|table }}
{% endfor %}

[stephangroen]

Thanks @WietseWind

Your code only applies this for financialtransaction/Transactions, but it seems to be possible for all endpoints with a Division, am I right?

If that is the case we could change this to be generally applicable to prevent inconsistent behaviour across entities.

[WietseWind]

@stephangroen It is, indeed. What would you propose? Checking for $this->url !== 'current/Me' in Findable, just as the check in the (Connection) get method when invoking the formatUrl method?

[stephangroen]

I think that should do the trick, Me is the only exceptional entity to this rule.

Could you also change the if statements to not be one-liners (include brackets)? This is more in line with the code style.

[kvij]

I do not know when'current/Me' is used but is it not enough to check $this->isFillable('Division') && preg_match...? This should also improve performance as the regexp is only executed on entities that have a Division attribute.

[WietseWind]

@stephangroen Fixed coding style
@kvij Done, better indeed.