Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add RTL #362

wants to merge 1 commit into from

Conversation

aliqasemzadeh
Copy link

Hello,
Please add this pull request to add RTL support for off-canvas.
I will more to make full RTL.

min-width: 10rem;
overflow-y: auto;
position: fixed;
top: 0;
transform: translateX(-100%);


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

min-width: 10rem;
overflow-y: auto;
position: fixed;
top: 0;
transform: translateX(-100%);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

left: 0;
@if $rtl == true {
transform: translateX(100%);
} @else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented with spaces, not tabs

@@ -20,12 +24,18 @@ $off-canvas-breakpoint: $size-lg !default;
.off-canvas-sidebar {
background: $bg-color;
bottom: 0;
left: 0;
@if $rtl == true {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented with spaces, not tabs

left: $layout-spacing;
@if $rtl == true {
right: $layout-spacing;
} @else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented with spaces, not tabs

@@ -10,7 +10,11 @@ $off-canvas-breakpoint: $size-lg !default;

.off-canvas-toggle {
display: block;
left: $layout-spacing;
@if $rtl == true {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented with spaces, not tabs

@picturepan2
Copy link
Owner

May I rewrite the code based on yours?

@aliqasemzadeh
Copy link
Author

Yes, you can.
Just I want to add full RTL support I will add more code in next days.

@picturepan2
Copy link
Owner

@aghasemzadeh Could you list all places that you will need RTL support? (Actually I am not a RTL habit guy. So I need your help.)

@aliqasemzadeh
Copy link
Author

yes,
I will list them and RTL support as pull request.

@aliqasemzadeh
Copy link
Author

@picturepan2 Please merge this pull after that I will edit all parts.

@pmpr
Copy link

pmpr commented Jan 5, 2019

@alighasemzadeh Hi Ali. My name is Peyman and I think we are both interested in RTL support in Spectre. Would you please tell me how much support does it already have, and do you need any help in this task ?

@hfsam
Copy link

hfsam commented Jan 5, 2019

I wanna check my bitcoin

@pmpr
Copy link

pmpr commented Jan 6, 2019

@picturepan2 Hi there. Thanks for your great job! I am going to be a fan of Spectre soon. Would you please tell me how can I engage in RTL support development?

I got the repository in my workstation and I am looking at src directory. Are there any documentation on how should one build dist from src resources?

@davestewart davestewart mentioned this pull request Sep 20, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants