Fix clean Micropython build #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah, I'd entirely forgot about this. Think this works around the fact that the QSTR preprocessing doesn't inherit the dependencies of the main build... by taking advantage of the code not needing to be entirely valid while that's happening. Should be fine unless there's a QSTR in a generated header for some reason. (Then again, not a python person so possibly speaking complete nonsense 🤷) |
|
Ah I've been just charging on through this every single time 😆 thank you. I'm glad it finally annoyed someone enough to stop, step back and fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble with my local MicroPython build for ages until @Daft-Freak suggested wrapping the
pio.hincludes like this.. I feel this should be in the standard build to avoid others having the same pain!