Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] asyncio for grpc data interactions #398

Draft
wants to merge 6 commits into
base: release-candidate/2025-01
Choose a base branch
from

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Oct 18, 2024

Problem

Describe the purpose of this change. What problem is being solved and why?

Solution

Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

Copy link

gitguardian bot commented Oct 18, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14203991 Triggered Generic High Entropy Secret e665c0d app2.py View secret
14203991 Triggered Generic High Entropy Secret e665c0d app3.py View secret
14203991 Triggered Generic High Entropy Secret e665c0d app2.py View secret
14203991 Triggered Generic High Entropy Secret 1c9632e app2.py View secret
14203991 Triggered Generic High Entropy Secret 1c9632e app2.py View secret
14203991 Triggered Generic High Entropy Secret 1c9632e app3.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@jhamon jhamon force-pushed the jhamon/grpc-asyncio branch 2 times, most recently from 2d5e0d2 to 0c9ecb7 Compare October 21, 2024 06:25
Comment on lines 150 to 151
if len(matches) == 0:
raise QueryResultsAggregationEmptyResultsError(ns)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't panic if a namespace doesn't return results. It is ok to return zero results, like in a case where the filter filtered out all the vectors in the namespace.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling this out. Jeff originally asked that we fail when namespace is incorrect, but that seems indistinguishable from the case where results are empty due to filtering. So I'm going to take this out.

@jhamon jhamon force-pushed the jhamon/grpc-asyncio branch from 4345ece to 247a329 Compare October 22, 2024 17:02
@jhamon jhamon changed the base branch from main to release-candidate/2024-10 November 14, 2024 18:21
This commit squashes several previous commits on this branch to
address a GitGuardian security check that continues to fail
because an early commit contained a leaked development key.
@jhamon jhamon force-pushed the jhamon/grpc-asyncio branch from 247a329 to b2e7b54 Compare November 14, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants