-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] asyncio for grpc data interactions #398
base: release-candidate/2025-01
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14203991 | Triggered | Generic High Entropy Secret | e665c0d | app2.py | View secret |
14203991 | Triggered | Generic High Entropy Secret | e665c0d | app3.py | View secret |
14203991 | Triggered | Generic High Entropy Secret | e665c0d | app2.py | View secret |
14203991 | Triggered | Generic High Entropy Secret | 1c9632e | app2.py | View secret |
14203991 | Triggered | Generic High Entropy Secret | 1c9632e | app2.py | View secret |
14203991 | Triggered | Generic High Entropy Secret | 1c9632e | app3.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
2d5e0d2
to
0c9ecb7
Compare
if len(matches) == 0: | ||
raise QueryResultsAggregationEmptyResultsError(ns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't panic if a namespace doesn't return results. It is ok to return zero results, like in a case where the filter filtered out all the vectors in the namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for calling this out. Jeff originally asked that we fail when namespace is incorrect, but that seems indistinguishable from the case where results are empty due to filtering. So I'm going to take this out.
4345ece
to
247a329
Compare
This commit squashes several previous commits on this branch to address a GitGuardian security check that continues to fail because an early commit contained a leaked development key.
247a329
to
b2e7b54
Compare
Problem
Describe the purpose of this change. What problem is being solved and why?
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Type of Change
Test Plan
Describe specific steps for validating this change.