mq(ticdc): implement producer interfrace using kafka-go #8146
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-triage-completed
release-note-none
| changefeedID := contextutil.ChangefeedIDFromCtx(ctx) | ||
| var role string | ||
| if contextutil.IsOwnerFromCtx(ctx) { | ||
| role = util.RoleOwner.String() |
There was a problem hiding this comment.
Why do we need a role in the context? For now, the owner always uses a sync writer to write DDL and the processor always uses an async writer to write DML.
There was a problem hiding this comment.
here, use the role to genereate kafka client ID , like sarama implementation
There was a problem hiding this comment.
What happened if we have more than one processor?
There was a problem hiding this comment.
the clientID is the same if we have more than one processor, it is the same logic with sarama
There was a problem hiding this comment.
So we don't need to add the role to the client ID. Because it is useless.
Co-authored-by: 二手掉包工程师 <[email protected]>
Co-authored-by: 二手掉包工程师 <[email protected]>
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 2afd9d7
|
ti-chi-bot
added
the
status/can-merge
|
/run-engine-integration-tests |
What problem does this PR solve?
Issue Number: close #8145
What is changed and how it works?
implement producer using kafka-go
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note