-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pino-abstract-transport #222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jsumners I know you preferred this to not become compatible with the new system, but the changes are minimal so I thought it was worth a shot. |
Pull Request Test Coverage Report for Build 1199229402
💛 - Coveralls |
cc @leorossi |
This was referenced Aug 30, 2021
jsumners
reviewed
Sep 3, 2021
Comment on lines
+207
to
+209
module.exports = build | ||
module.exports.prettyFactory = prettyFactory | ||
module.exports.default = build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is semver major.
@jsumners updated the require order. |
jsumners
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes this module compatible with the new transport system.
This is the first step for pinojs/pino#1106.
It is a semver-major change and it will require a minor change in pino@6 and pino@7 to achieve compatibility. before we exported the
prettyFactory
, now we export the function to build a transport, which includes split2.