Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pino-abstract-transport #222

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Use pino-abstract-transport #222

merged 4 commits into from
Sep 3, 2021

Conversation

mcollina
Copy link
Member

This change makes this module compatible with the new transport system.

This is the first step for pinojs/pino#1106.

It is a semver-major change and it will require a minor change in pino@6 and pino@7 to achieve compatibility. before we exported the prettyFactory, now we export the function to build a transport, which includes split2.

@mcollina
Copy link
Member Author

@jsumners I know you preferred this to not become compatible with the new system, but the changes are minimal so I thought it was worth a shot.

@coveralls
Copy link

coveralls commented Aug 29, 2021

Pull Request Test Coverage Report for Build 1199229402

  • 30 of 30 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1152274912: 0.0%
Covered Lines: 319
Relevant Lines: 319

💛 - Coveralls

@mcollina
Copy link
Member Author

cc @leorossi

bin.js Outdated Show resolved Hide resolved
bin.js Outdated Show resolved Hide resolved
Comment on lines +207 to +209
module.exports = build
module.exports.prettyFactory = prettyFactory
module.exports.default = build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is semver major.

@mcollina
Copy link
Member Author

mcollina commented Sep 3, 2021

@jsumners updated the require order.

@mcollina mcollina merged commit 72808da into master Sep 3, 2021
@Fdawgs Fdawgs deleted the use-abstract-transport branch August 19, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants