Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dateformat migrated to esm #234

Merged
merged 4 commits into from
Sep 21, 2021
Merged

fix: dateformat migrated to esm #234

merged 4 commits into from
Sep 21, 2021

Conversation

climba03003
Copy link
Contributor

@climba03003 climba03003 commented Sep 21, 2021 •
edited
Loading

As dateformat moved from CJS to ESM.
Change the version to ~ flag to prevent further impact.

Related to pinojs/pino#1137

@climba03003 climba03003 changed the title fix: esm package migration fix: dateformat migrated to esm Sep 21, 2021
@climba03003
Copy link
Contributor Author

It seems that coveralls is blocking the CI. 405 problems again.

@kibertoad
Copy link
Contributor

Should be finished soon: https://status.coveralls.io/?utm_source=embed

@climba03003
Copy link
Contributor Author

I will either use continue-on-error for Coveralls or disable it until the maintenance is over.

Coveralls should not be the blocker for CI.

@kibertoad
Copy link
Contributor

continue-on-error sounds like a great idea!

@kibertoad
Copy link
Contributor

@climba03003 Can you try 4.6.2? If I'm reading https://github.com/felixge/node-dateformat/releases right, looks like they realized their mistake.

@climba03003
Copy link
Contributor Author

@climba03003 Can you try 4.6.2? If I'm reading https://github.com/felixge/node-dateformat/releases right, looks like they realized their mistake.

@kibertoad I will use 4.6.3 as it is the latest in npmjs. And I have updated the CI to skip or allow all the stage of coveralls to fail.

mcollina
mcollina approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7e802b4 into pinojs:master Sep 21, 2021
@renovate renovate bot mentioned this pull request Oct 23, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@climba03003 @kibertoad @mcollina