Improve TS types #1099
Merged
Improve TS types #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix index type
kibertoad
commented
Aug 26, 2021
| @@ -71,7 +71,7 @@ | |||
| "bunyan": "^1.8.14", | |||
| "docsify-cli": "^4.4.1", | |||
| "eslint": "^7.17.0", | |||
| "eslint-config-standard": "^16.0.2", | |||
| "eslint-config-standard": "^16.0.3", | |||
There was a problem hiding this comment.
npm 7 was screaming at me about failing to resolve dependencies unless I bumped this.
kibertoad
commented
Aug 26, 2021
| @@ -50,7 +50,6 @@ declare namespace P { | |||
| /** | |||
| * Holds the current log format version (as output in the v property of each log record). | |||
| */ | |||
| const LOG_VERSION: number; | |||
There was a problem hiding this comment.
this no longer seems to exist
kibertoad
commented
Aug 26, 2021
|
|
||
| interface BaseLogger extends EventEmitter { | ||
| /** |
There was a problem hiding this comment.
none of these fields seem to exist anymore on a logger instance (version is exposed as a separate exported constant, though)
kibertoad
commented
Aug 26, 2021
| @@ -870,6 +806,63 @@ declare namespace P { | |||
| * Noop function. | |||
| */ | |||
| silent: LogFn; | |||
| } | |||
|
|
|||
| interface LoggerExtras extends EventEmitter { | |||
There was a problem hiding this comment.
Not a huge fan of the name, open for better suggestions
This was referenced Aug 26, 2021
|
@mcollina Any chance you could release new RC? |
|
@mcollina Are there any pending changes before we can publish a new RC? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on fastify/fastify#3101 I've noticed following things:
Loggeris not correct, as all members of an object must conform to the string index signature (see https://stackoverflow.com/questions/57371839/merge-typescript-record-or-dictionary-like-type-with-fixed-key-typings)