Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DestinationStreamMetadata type to pino.d.ts #1566

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Add DestinationStreamMetadata type to pino.d.ts #1566

merged 4 commits into from
Oct 6, 2022

Conversation

segevfiner
Copy link
Contributor

Fixes #1557

mcollina
mcollina requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd for TypeScript.

@segevfiner
Copy link
Contributor Author

Looks like this won't work with Symbol.for, as it is not supported in d.ts microsoft/TypeScript#35909 and we don't export this symbol AFAIK. We will need to export it to be able to do this.

@mcollina
Copy link
Member

Export it too.

@segevfiner segevfiner requested a review from mcollina October 4, 2022 11:29
mcollina
mcollina approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7c425f1 into pinojs:master Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding stream metadata types to pino.d.ts
2 participants
@segevfiner @mcollina