-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomic async writes #102
Atomic async writes #102
Conversation
I resolved most of the preformance regressions introduced for the async and sync case. However it still degrades the performance if This branch:
master:
Those were taken on Node.js v16. |
index.js
Outdated
actualWrite(this) | ||
} | ||
return len < 16384 | ||
|
||
return len < 163874 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
@mcollina pino still suffers from this problem since it has sonic-boom v1 as dependency. Could we bump it on pino v6? |
You can use sonic-boom with pino@6, just instantiate one and pass it as a stream. Unfortunately there are a few semver-major changes in there. |
Fixes: #96