Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require fallback #34

Merged
merged 8 commits into from
Sep 3, 2021
Merged

require fallback #34

merged 8 commits into from
Sep 3, 2021

Conversation

Eomm
Copy link
Contributor

@Eomm Eomm commented Sep 2, 2021

Adding the require fallback to support yarn in PnP mode.

Added workflows to test it.
Note I had to add a new script in package.json because the mjs files do not work with yarn (it doesn't support esm yet)

There is a repetitive warnings in the output

test/thread-management.test.js 2> (node:3755) [MODULE_NOT_FOUND] Error: debug tried to access supports-color (a peer dependency) but it isn't provided by its ancestors; this makes the require call ambiguous and unsound.

caused by some dependencies that have not added the module into their package json.
Not sure it is worth some investigation

Reference pinojs/pino#1113

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some doc about this in the README?

lib/worker.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Eomm
Copy link
Contributor Author

Eomm commented Sep 3, 2021

Done

Note that the workflows did not run into this repository yet

2 workflows awaiting approval

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1197132018

  • -3 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.0%) to 85.427%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/worker.js 2 5 40.0%
Totals Coverage Status
Change from base Build 1116213907: -2.0%
Covered Lines: 260
Relevant Lines: 289

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 3, 2021

Pull Request Test Coverage Report for Build 1197132018

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 85.678%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/worker.js 2 5 40.0%
Totals Coverage Status
Change from base Build 1116213907: -1.7%
Covered Lines: 261
Relevant Lines: 289

💛 - Coveralls

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0a01728 into pinojs:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants