Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10026] Make TraceService, SqlMetaDataService abstract #10021

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

kojandy
Copy link
Contributor

@kojandy kojandy commented Jun 5, 2023

Resolves #10026.

@kojandy kojandy added this to the 2.6.0 milestone Jun 5, 2023
@kojandy kojandy requested a review from emeroad June 5, 2023 11:01
@kojandy kojandy self-assigned this Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #10021 (e627aa4) into master (91c9ba7) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head e627aa4 differs from pull request most recent head 928a9a4. Consider uploading reports for the commit 928a9a4 to get more accurate results

@@             Coverage Diff              @@
##             master   #10021      +/-   ##
============================================
+ Coverage     38.58%   38.60%   +0.01%     
- Complexity    11626    11632       +6     
============================================
  Files          3574     3574              
  Lines         93341    93353      +12     
  Branches      10320    10326       +6     
============================================
+ Hits          36017    36038      +21     
+ Misses        54236    54229       -7     
+ Partials       3088     3086       -2     
Impacted Files Coverage Δ
.../navercorp/pinpoint/bootstrap/config/Profiles.java 0.00% <ø> (ø)
...npoint/bootstrap/config/ProfilePropertyLoader.java 20.00% <0.00%> (+0.30%) ⬆️
...t/collector/handler/grpc/GrpcSpanChunkHandler.java 0.00% <0.00%> (ø)
...npoint/collector/handler/grpc/GrpcSpanHandler.java 0.00% <0.00%> (ø)
...collector/handler/grpc/GrpcSqlMetaDataHandler.java 0.00% <0.00%> (ø)
...int/collector/service/HbaseSqlMetaDataService.java 0.00% <0.00%> (ø)
.../pinpoint/collector/service/HbaseTraceService.java 0.00% <0.00%> (ø)
...orp/pinpoint/tools/NetworkAvailabilityChecker.java 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

@kojandy kojandy changed the title [#noissue] Make TraceService, SqlMetaDataService abstract [#10026] Make TraceService, SqlMetaDataService abstract Jun 8, 2023
@kojandy kojandy merged commit 0a68cc4 into pinpoint-apm:master Jun 8, 2023
@kojandy kojandy deleted the feature/abstract branch June 8, 2023 09:35
@kojandy kojandy restored the feature/abstract branch June 8, 2023 09:35
@kojandy kojandy deleted the feature/abstract branch June 8, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make TraceService, SqlMetaDataService abstract
1 participant