Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Refactor GrpcSpanBinder #10056

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 19, 2023

No description provided.

@emeroad emeroad added this to the 2.6.0 milestone Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #10056 (a042c6f) into master (ac0c445) will decrease coverage by 0.01%.
The diff coverage is 44.73%.

@@             Coverage Diff              @@
##             master   #10056      +/-   ##
============================================
- Coverage     38.59%   38.59%   -0.01%     
- Complexity    11629    11633       +4     
============================================
  Files          3577     3578       +1     
  Lines         93376    93389      +13     
  Branches      10327    10327              
============================================
+ Hits          36037    36039       +2     
- Misses        54256    54263       +7     
- Partials       3083     3087       +4     
Impacted Files Coverage Δ
...t/collector/handler/grpc/GrpcSpanChunkHandler.java 0.00% <0.00%> (ø)
...npoint/collector/handler/grpc/GrpcSpanHandler.java 0.00% <0.00%> (ø)
.../main/java/com/navercorp/pinpoint/grpc/Header.java 48.21% <0.00%> (ø)
...pinpoint/common/server/bo/grpc/GrpcSpanBinder.java 39.73% <45.45%> (+0.40%) ⬆️
...ommon/server/bo/grpc/CollectorGrpcSpanFactory.java 77.41% <66.66%> (+2.41%) ⬆️
.../pinpoint/common/server/bo/grpc/BindAttribute.java 76.92% <76.92%> (ø)

... and 14 files with indirect coverage changes

@emeroad emeroad merged commit ba76b3f into pinpoint-apm:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant