Fixing bug with extra indentation after lambda arrow (#508)

* Fixing bug with extra indentation after lambda arrow Fixes #479 * Adding tests
pinterest · Jul 5, 2019 · f4e5358 · f4e5358
1 parent ba513d7
commit f4e5358
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 5 deletions.
diff --git a/...experimental/src/main/kotlin/com/pinterest/ktlint/ruleset/experimental/IndentationRule.kt b/...experimental/src/main/kotlin/com/pinterest/ktlint/ruleset/experimental/IndentationRule.kt
@@ -707,11 +707,14 @@ class IndentationRule : Rule("indent"), Rule.Modifier.RestrictToRootLast {
     }
 
     private fun adjustExpectedIndentAfterArrow(n: ASTNode, ctx: IndentContext) {
-        val prevBlockLine = ctx.blockOpeningLineStack.peek() ?: -1
-        if (prevBlockLine != line) {
-            expectedIndent++
-            debug { "++after(ARROW) -> $expectedIndent" }
-            ctx.exitAdjBy(n.treeParent, -1)
+        // Only adjust indents for arrows inside of when statements. Lambda arrows should not increase indent.
+        if (n.treeParent?.elementType == WHEN_ENTRY) {
+            val prevBlockLine = ctx.blockOpeningLineStack.peek() ?: -1
+            if (prevBlockLine != line) {
+                expectedIndent++
+                debug { "++after(ARROW) -> $expectedIndent" }
+                ctx.exitAdjBy(n.treeParent, -1)
+            }
         }
     }
 

diff --git a/...rimental/src/test/kotlin/com/pinterest/ktlint/ruleset/experimental/IndentationRuleTest.kt b/...rimental/src/test/kotlin/com/pinterest/ktlint/ruleset/experimental/IndentationRuleTest.kt
@@ -322,4 +322,26 @@ class IndentationRuleTest {
             )
         ).isEmpty()
     }
+
+    @Test
+    fun `no indentation after lambda arrow`() {
+        assertThat(
+            IndentationRule().lint(
+                """
+                fun bar() {
+                    foo.func {
+                        param1, param2 ->
+                            doSomething()
+                            doSomething2()
+                    }
+                }
+                """.trimIndent()
+            )
+        ).isEqualTo(
+            listOf(
+                LintError(line = 4, col = 1, ruleId = "indent", detail = "Unexpected indentation (12) (should be 8)"),
+                LintError(line = 5, col = 1, ruleId = "indent", detail = "Unexpected indentation (12) (should be 8)")
+            )
+        )
+    }
 }
diff --git a/ktlint-ruleset-experimental/src/test/resources/spec/indent/format-arrow-expected.kt.spec b/ktlint-ruleset-experimental/src/test/resources/spec/indent/format-arrow-expected.kt.spec
@@ -23,4 +23,9 @@ fun main() {
         2 // second element
         -> true
     }
+    foo.func {
+        param1, param2 ->
+        doSomething()
+        doSomething2()
+    }
 }
diff --git a/ktlint-ruleset-experimental/src/test/resources/spec/indent/format-arrow.kt.spec b/ktlint-ruleset-experimental/src/test/resources/spec/indent/format-arrow.kt.spec
@@ -20,4 +20,9 @@ fun main() {
         2 // second element
         -> true
     }
+    foo.func {
+        param1, param2 ->
+            doSomething()
+            doSomething2()
+        }
 }