Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: NoSpaceBetweenParentheses #232

Closed
wants to merge 1 commit into from
Closed

Rule: NoSpaceBetweenParentheses #232

wants to merge 1 commit into from

Conversation

MyDogTom
Copy link
Contributor

New rule forbids redundant spaces between parentheses. Fixes #223

Correct:

fun main() {}

fun main(a: String) {}

Wrong:

fun main( ) {}

fun main(
) {}

@MyDogTom
Rule: NoSpaceBetweenParentheses
5e06aba 
New rule forbids redundant spaces between parentheses. Fixes pinterest#223
vanniktech
vanniktech approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👍

@shyiko
Copy link
Collaborator

shyiko commented Jun 23, 2018

I'm really sorry @MyDogTom but I have to close this PR.
( ) is handled by SpacingAroundParensRule which checks a much broader set of cases
(included in 0.24.0).
Thank you the effort, though.

@shyiko shyiko closed this Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MyDogTom @shyiko @vanniktech