Remove code that was inserting newline after = in a chained call #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shashachu
commented
Apr 19, 2019
shashachu
commented
- Fixes IndentationRule inserting unnecessary line break after assignment followed by any continuation #368 and MissingNewLine triggered on builder chain like pattern #380
- Kotlin styleguide: https://kotlinlang.org/docs/reference/coding-conventions.html#chained-call-wrapping
- Says 'The first call in the chain usually should have a line break before it, but it's OK to omit it if the code makes more sense that way.'
shashachu
force-pushed
the
extra-newline
branch
from
20bc8f1 to
0ba9b1a
Compare
|
@vanniktech thoughts on this one? I just removed the code that was inserting the newline after the |
JLLeitschuh
suggested changes
Apr 24, 2019
...experimental/src/test/resources/spec/indent/format-dot-qualified-expression-expected.kt.spec
Show resolved
Hide resolved
...t-experimental/src/test/resources/spec/indent/format-raw-string-trim-indent-expected.kt.spec
Outdated
Show resolved
Hide resolved
|
I re-introduced the rule for raw strings but removed the rest. I also added a test verifying the linebreak after = in chained calls is still allowed, just not forced. |
NightlyNexus
approved these changes
May 22, 2019
...xperimental/src/test/kotlin/com/pinterest/ktlint/ruleset/experimental/IndentationRuleTest.kt
Outdated
Show resolved
Hide resolved
| val x = | ||
| "a" + | ||
| "b2" | ||
| val x = "a" + |
There was a problem hiding this comment.
i don't know if this better...
There was a problem hiding this comment.
really? it seems better to me. but the previous formatting is still allowed, just not forced.
| ) + f1( | ||
| "sssss" | ||
| ) | ||
| val x = paths.flatMap { dir -> |
There was a problem hiding this comment.
this does seem slightly better, though
| get() = | ||
| this.javaClass.name | ||
| .fn() | ||
| get() = this.javaClass.name |
There was a problem hiding this comment.
both look bad to me, but the extra newline irks me. maybe it's just me. :)
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
…terest#387) * Remove code that was inserting newline after = except for raw strings
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jun 10, 2019
…terest#387) * Remove code that was inserting newline after = except for raw strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.