feat: Added datadoc and list access permissions for user groups #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Feb 5, 2025
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "querybook", | |||
| "version": "3.38.0", | |||
| "version": "3.38.1", | |||
| from enum import Enum | ||
|
|
||
|
|
||
| class Permission(Enum): |
There was a problem hiding this comment.
EntityPermission? probably more clear with a comment on where this is used
|
|
||
|
|
||
| @with_session | ||
| def assert_is_not_group(id, session=None): |
There was a problem hiding this comment.
name is a bit generic, can we rename id to board_editor_id
Comment on lines
95
to
96
| if user is None: | ||
| api_assert(False, "USER_DNE", RESOURCE_NOT_FOUND_STATUS_CODE) |
There was a problem hiding this comment.
uid = sql.Column(sql.Integer, sql.ForeignKey("user.id", ondelete="CASCADE"))
this check is not needed? since sql constraints to prevent it
querybook/server/logic/board.py
Outdated
|
|
||
| return [ | ||
| BoardEditor( | ||
| # [0] is id, [1] is uid, [2] is read, [3] is write |
There was a problem hiding this comment.
comment is not needed?
seems to be more ideal to write like this
for id, uid, read, write in editors
| if (uid in editorsByUid || uid === board.owner_uid) { | ||
| if ( | ||
| uid === board.owner_uid || | ||
| (uid in editorsByUid && editorsByUid[uid].id !== null) |
There was a problem hiding this comment.
!!editorsByUid[uid]?.idseems easier to just check this
| @@ -20,33 +22,40 @@ export function readWriteToPermission( | |||
| read: boolean, | |||
| write: boolean, | |||
| isOwner: boolean, | |||
| publicDoc: boolean | |||
| publicDoc: boolean, | |||
There was a problem hiding this comment.
publicDoc isn't used? should we remove?
| @@ -20,33 +22,40 @@ export function readWriteToPermission( | |||
| read: boolean, | |||
| write: boolean, | |||
| isOwner: boolean, | |||
| publicDoc: boolean | |||
| publicDoc: boolean, | |||
| id: number | |||
There was a problem hiding this comment.
instead of id field, it should be a boolean to indicate if its a permissionFromGroup
| (dataDoc, editorsByUserId, viewerIds) => { | ||
| (state: IStoreState) => state.user.myUserInfo.uid, | ||
| (dataDoc, editorsByUserId, viewerIds, uid) => { | ||
| const newEditorsByUserId = Object.fromEntries( |
Co-authored-by: Ana <[email protected]>
jczhong84
force-pushed
the
external/group-permissions
branch
from
bbe8c13 to
87284e3
Compare
czgu
previously approved these changes
Feb 6, 2025
zhangvi7
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR of #1297 (author: @jij1949), with rebasing and adding some demo users.