Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote url to fix equal sign breaking outlook clients #80

Merged
merged 3 commits into from
May 7, 2018
Merged

Quote url to fix equal sign breaking outlook clients #80

merged 3 commits into from
May 7, 2018

Conversation

nichochar
Copy link
Collaborator

Fix #73

jparise
jparise reviewed May 7, 2018
View reviewed changes
Copy link
Collaborator

@jparise jparise left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use werkzeug.urls.url_quote_plus and werkzeug.urls.url_unquote_plus instead. We already have a Werkzeug dependency (because of Flask), and those are slightly nicer functions for this transformation.

@nichochar
Copy link
Collaborator Author

Good idea, it's cleaner, updated.

@nichochar nichochar merged commit 68b4cec into master May 7, 2018
@nichochar nichochar deleted the quoteurls branch May 7, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparise jparise jparise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nichochar @jparise