Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily fix deprecation #35

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Temporarily fix deprecation #35

merged 3 commits into from
Nov 10, 2023

Conversation

stanislav-janu
Copy link
Contributor

PHP 8.2 Notice: Deprecated: Return type of SmartEmailing\v3\Models\AbstractHolder::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

…bstractHolder::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed
@pionl
Copy link
Owner

pionl commented Oct 27, 2023

Myslíš že by si mohl opravit ten phpstan?

@stanislav-janu
Copy link
Contributor Author

Opraven.

@pionl
Copy link
Owner

pionl commented Nov 10, 2023

Děkuji!

@pionl pionl merged commit 2f0064b into pionl:main Nov 10, 2023
11 checks passed
@pionl
Copy link
Owner

pionl commented Nov 10, 2023

vydáno v1.0.0-rc-2 - mám už vydat final release? jsou změny od @MartinMystikJonas ok?

@stanislav-janu
Copy link
Contributor Author

Vypadá to funkčně. Aktualizoval jsem a chyby mi to nehlásí. Ale důkladné testování to nebylo :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants