Fix race condition when applying styles to sidebar #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I missed that, thanks! |
|
Related to this topic, I've introduced more changes to append the "style" query parameter by TST side with the commit dca685c. Now separate sidebar window will be shown with the chosen theme without any lag. |
|
Wow, thanks! I really appreciate how well you support helper extensions for Tree Style Tab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing my Tree Style Tab in Separate Window helper extension I noticed that the style is a bit messed up when the sidebar page is opened in a normal tab (and therefore also when it is opened in another window). To be precise I have dark theme enabled and the active tab is highlighted in white. I tracked the problem down to a race condition and confirmed that the change in this PR fixes it.
Sidebar page to the left and normal sidebar to the right:
