Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher to use caller thread instead of dedicated scheduler thread #789

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

pivovarit
Copy link
Owner

@pivovarit pivovarit commented Oct 10, 2023

Remove the internal single-thread scheduler and rely on the caller thread to submit all relevant tasks to a given thread pool. This not only simplified the solution, but also:

  • helped avoid context propagation issues when execution switches between multiple threads
  • made the tool more Loom-friendly since instances of ParallelCollectors do not create their own threads

@pivovarit pivovarit force-pushed the remove-thread-per-collector branch 14 times, most recently from d936a74 to 204e532 Compare October 11, 2023 05:52
@pivovarit pivovarit marked this pull request as ready for review October 11, 2023 07:00
@pivovarit pivovarit force-pushed the remove-thread-per-collector branch 3 times, most recently from 1976d8d to 31700cc Compare October 11, 2023 10:03
@pivovarit pivovarit merged commit c48c915 into master Oct 12, 2023
1 check passed
@pivovarit pivovarit deleted the remove-thread-per-collector branch October 12, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant