Add codemodder framework and replace 1 codemod #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trying to get 1 codemod to run side by side
nahsra
commented
Mar 12, 2023
| @@ -16,9 +15,6 @@ public interface FileWeavingContext { | |||
|
|
|||
| boolean madeWeaves(); | |||
|
|
|||
There was a problem hiding this comment.
Took out this tight coupling to JavaParser as this class is intended to be used generally.
gilday
reviewed
Mar 13, 2023
languages/codemodder-framework-java/src/main/java/io/codemodder/CodemodInvoker.java
Outdated
Show resolved
Hide resolved
...es/codemodder-default-codemods/src/main/java/io/codemodder/codemods/SecureRandomCodemod.java
Outdated
Show resolved
Hide resolved
...es/codemodder-default-codemods/src/main/java/io/codemodder/codemods/SecureRandomCodemod.java
Outdated
Show resolved
Hide resolved
...es/codemodder-default-codemods/src/main/java/io/codemodder/codemods/SecureRandomCodemod.java
Outdated
Show resolved
Hide resolved
languages/codemodder-default-codemods/src/main/resources/secure-random.semgrep
Outdated
Show resolved
Hide resolved
gilday
approved these changes
Mar 14, 2023
| id("io.openpixee.codetl.base") | ||
| id("io.openpixee.codetl.java-library") | ||
| id("io.openpixee.codetl.maven-publish") | ||
| id("application") |
There was a problem hiding this comment.
It's unusual to have the application and java-library plugins in a project. Do we need the application plugin? I understand this is a library.
There was a problem hiding this comment.
I don't understand these so I just copied them all from the root to every new project. 😓
There was a problem hiding this comment.
io.openpixee.codetl.baseis our conventions on top of Gradle's base plugin. It defines things constant to all buildscripts like buildscript formatting. It's usually implied by other plugins e.g.java-library: I can't recall if that's the case here.io.openpixee.codetl.java-libraryis our conventions on top of Gradle's java library plugin. It's used to define a library used by other Java projects.applicationis Gradle's application plugin. We don't have conventions for this one, I don't think we use it I can't remember.io.openpixee.codetl.maven-publishis our conventions on top of Gradle's maven publish plugin. It's for publishing artifacts to a Maven repository. We only include it if we need to publish the artifact to a Maven repository.
| } | ||
| } | ||
|
|
||
| spotless { |
There was a problem hiding this comment.
So I can delete all the spotless kotlins from the new projects?
There was a problem hiding this comment.
right, the formatting is being applied by the plugins at the top of this build script.
...es/codemodder-default-codemods/src/main/java/io/codemodder/codemods/SecureRandomCodemod.java
Show resolved
Hide resolved
...odder-semgrep-provider/src/main/java/io/codemodder/providers/sarif/semgrep/SemgrepSarif.java
Outdated
Show resolved
Hide resolved
...modder-semgrep-provider/src/main/java/io/codemodder/providers/sarif/semgrep/SemgrepScan.java
Show resolved
Hide resolved
...-semgrep-provider/src/test/java/io/codemodder/providers/sarif/semgrep/SemgrepRunnerTest.java
Outdated
Show resolved
Hide resolved
languages/java/src/test/java/io/openpixee/java/protections/WeavingTests.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new codemodder framework, including an example provider, and a single codemod replacing the old way of doing things.