Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, allow aws-sdk configuration for multi-region support #3

Merged
merged 2 commits into from
May 8, 2019

Conversation

dylansmith
Copy link

@dylansmith dylansmith commented May 8, 2019

Updated all deps and resolved npm audit issues. Refactored to use dependency injection for the AWS SDK, making it configurable at the top level. Have tested it working by specifying new Credstash({region: 'eu-west-1'}) and running with AWS_DEFAULT_REGION=us-east-1.

@dylansmith dylansmith requested a review from caoilte May 8, 2019 10:15
Copy link

@caoilte caoilte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable.

@dylansmith dylansmith merged commit f8d5458 into master May 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the multiregion branch May 8, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants