Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for fee recipieint changes #1

Merged
merged 15 commits into from
Jan 25, 2022

Conversation

paulhauner
Copy link

@paulhauner paulhauner commented Jan 25, 2022

Issue Addressed

NA

Proposed Changes

Adds some suggested changes as a part of a review on sigp#2924:

  • Renames the --fee-recipient flag to --suggested-fee-recipient for consistency with engine API.
  • Adds the suggested_fee_recipient to the validator_definitions.yml file.
  • Adds documentation about the fee recipient.
  • The now VC polls the prepare endpoing on the BN once per slot.
  • The VC will immediately poll the prepare endpoint when the PreparationService starts.
  • Removes the hard-coded default fee-recipient from the BN. It was marked with a TODO and needed to be removed.

Additional Info

NA

@pk910 pk910 merged commit 87a0e14 into pk910:fee-recipient-per-validator Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants